Reduce the number of runtime exceptions (SecurityModuleException) #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith the new format (EIP-8), and if there is an exception, try the old format. This will reduce the number of exceptions and unnecessary executions. Signed-off-by: Ameziane H <[email protected]>
fab-10
approved these changes
Oct 11, 2022
garyschulte
approved these changes
Oct 11, 2022
macfarla
approved these changes
Oct 12, 2022
Signed-off-by: Ameziane H <[email protected]>
ahamlat
force-pushed
the
reduce-handshake-exceptions
branch
from
5de2862
to
e4b1101
Compare
Signed-off-by: Ameziane H <[email protected]>
Signed-off-by: ahamlat <[email protected]>
fab-10
approved these changes
Oct 12, 2022
Signed-off-by: Ameziane H <[email protected]>
…o reduce-handshake-exceptions
fab-10
pushed a commit
to fab-10/besu
that referenced
this pull request
Oct 19, 2022
…perledger#4508) * During handshake, flip the encrypted message decryption by starting with the new format (EIP-8), and if there is an exception, try the old format. This will reduce the number of exceptions and unnecessary executions. Signed-off-by: Ameziane H <[email protected]> * update CHANGELOG.md to give more context on this PR. Signed-off-by: Ameziane H <[email protected]> * update CHANGELOG.md to give more context on this PR. Signed-off-by: Ameziane H <[email protected]> * Delete some debug code committed by error Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: ahamlat <[email protected]>
fab-10
added a commit
that referenced
this pull request
Oct 19, 2022
* The block variable was keeping too much memory while waiting for future to finish (#4489) Signed-off-by: Jiri Peinlich <[email protected]> * Reduce the number of runtime exceptions (SecurityModuleException) (#4508) * During handshake, flip the encrypted message decryption by starting with the new format (EIP-8), and if there is an exception, try the old format. This will reduce the number of exceptions and unnecessary executions. Signed-off-by: Ameziane H <[email protected]> * update CHANGELOG.md to give more context on this PR. Signed-off-by: Ameziane H <[email protected]> * update CHANGELOG.md to give more context on this PR. Signed-off-by: Ameziane H <[email protected]> * Delete some debug code committed by error Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: ahamlat <[email protected]> * Upgrade Apache Commons Text to 1.10.0 (#4542) * upgraded Apache Commons Text to fix CVE-2022-42889 Signed-off-by: Daniel Lehrner <[email protected]> * add changelog Signed-off-by: garyschulte <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> Signed-off-by: garyschulte <[email protected]> Co-authored-by: garyschulte <[email protected]> * Tune EthScheduler thread pools to avoid to recreate too many threads (#4529) Signed-off-by: Fabio Di Fabio <[email protected]> * Make GraphQL scalar parsing compatible with variables (#4522) Our current GraphQL scalar parsing interacts poorly with the variables support in the library. Revise the parsing so it works correctly. Signed-off-by: Danno Ferrin <[email protected]> * don't add to bad blocks manager on StorageException (#4524) * don't add to bad blocks manager on StorageException * add bugfix to changelog * adds test coverage Signed-off-by: Justin Florentine <[email protected]> * CHANGELOG for 22.7.7 Signed-off-by: Fabio Di Fabio <[email protected]> * Release 22.7.7 Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Jiri Peinlich <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: ahamlat <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]> Signed-off-by: garyschulte <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Justin Florentine <[email protected]> Co-authored-by: Jiri Peinlich <[email protected]> Co-authored-by: ahamlat <[email protected]> Co-authored-by: Daniel Lehrner <[email protected]> Co-authored-by: garyschulte <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Justin Florentine <[email protected]>
macfarla
pushed a commit
to jflo/besu
that referenced
this pull request
Jan 10, 2023
…perledger#4508) * During handshake, flip the encrypted message decryption by starting with the new format (EIP-8), and if there is an exception, try the old format. This will reduce the number of exceptions and unnecessary executions. Signed-off-by: Ameziane H <[email protected]> * update CHANGELOG.md to give more context on this PR. Signed-off-by: Ameziane H <[email protected]> * update CHANGELOG.md to give more context on this PR. Signed-off-by: Ameziane H <[email protected]> * Delete some debug code committed by error Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: ahamlat <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…perledger#4508) * During handshake, flip the encrypted message decryption by starting with the new format (EIP-8), and if there is an exception, try the old format. This will reduce the number of exceptions and unnecessary executions. Signed-off-by: Ameziane H <[email protected]> * update CHANGELOG.md to give more context on this PR. Signed-off-by: Ameziane H <[email protected]> * update CHANGELOG.md to give more context on this PR. Signed-off-by: Ameziane H <[email protected]> * Delete some debug code committed by error Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: ahamlat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ameziane H [email protected]
PR description
During handshake, flip the encrypted message decryption by starting with the new format (EIP-8), and if there is an exception, try the old format. This will reduce the number of exceptions and unnecessary executions.
I noticed by adding some debug logs that on 4400 calls to ECIESHandshaker.handleMessage, there're only 7 cases where the encrypted message has the old format.
By changing the order of execution, starting by decoding the new format (eip8) and without resetting the logs, we can notice there're no more exceptions
There is one case I'm not sure about it : if (buf.writerIndex() < size), do we need to try to decode with the old format or we should just throw HandshakeException. With the current PR, HandshakeException will be caught and the old format decryption will be executed.
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog