Add post-run allocation output to EVMTool #4709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shemnon
added
the
doc-change-required
|
Doc change: EVM Tool adds a new This flag is specified in the same places |
|
Quick question, couldn't Jackson be used to serialize the alloc? |
macfarla
reviewed
Nov 24, 2022
ethereum/evmtool/src/main/java/org/hyperledger/besu/evmtool/StateTestSubCommand.java
Outdated
Show resolved
Hide resolved
ethereum/evmtool/src/main/java/org/hyperledger/besu/evmtool/EvmToolCommand.java
Outdated
Show resolved
Hide resolved
ethereum/evmtool/src/main/java/org/hyperledger/besu/evmtool/EvmToolCommand.java
Show resolved
Hide resolved
Add a CLI flag --json-alloc that will output the post-execution state of the allocations the EVM Tool executed in. As well as post-execution state for state-tests. Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
|
Why not jackson? Jackson is in-memory whereas printstream/printwriter allows us to stream the results, reducing the required memory footprint. In theory if hooked up to a on-disk database it could walk the whole data stream too. |
Signed-off-by: Danno Ferrin <[email protected]>
shemnon
force-pushed
the
evmtool-alloc
branch
from
fc10290
to
bb5948a
Compare
Signed-off-by: Danno Ferrin <[email protected]>
diega
approved these changes
Dec 22, 2022
rolandtyler
removed
the
doc-change-required
macfarla
pushed a commit
to jflo/besu
that referenced
this pull request
Jan 10, 2023
* Add post-run allocation output to EVMTool Add a CLI flag --json-alloc that will output the post-execution state of the allocations the EVM Tool executed in. As well as post-execution state for state-tests. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Add post-run allocation output to EVMTool Add a CLI flag --json-alloc that will output the post-execution state of the allocations the EVM Tool executed in. As well as post-execution state for state-tests. Signed-off-by: Danno Ferrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add a CLI flag --json-alloc that will output the post-execution state of the allocations the EVM Tool executed in. As well as post-execution state for state-tests.
Signed-off-by: Danno Ferrin [email protected]
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog