Add worldstate heal mechanism #5059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim TAAM <[email protected]>
|
Initial PR is here #4972 |
siladu
reviewed
Feb 7, 2023
Comment on lines
+47
to
+49
| return firstHeader -> | ||
| blockchain.contains(firstHeader.getParentHash()) | ||
| && blockchain.getChainHeadBlockNumber() + 1 >= firstHeader.getNumber(); |
There was a problem hiding this comment.
@matkt This appears to be different from the other PR: https://github.com/hyperledger/besu/pull/4972/files#diff-0361d2ff12cd43f507bf88a3cb4d781a537ca765329e0811f60a9507527cbe13R47
There was a problem hiding this comment.
looks fine though, I will assume it's an extra safety check.
There was a problem hiding this comment.
...ah just caught up with the new comments from the old PR :)
#4972 (comment)
There was a problem hiding this comment.
It's fine . It's a fix
siladu
approved these changes
Feb 7, 2023
macfarla
reviewed
Feb 7, 2023
Merged
ensi321
pushed a commit
to ensi321/besu
that referenced
this pull request
Feb 19, 2023
Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karim TAAM [email protected]
PR description
This PR add a heal mechanism fo the worldtstate in case of inconsistency (unable to trie node). To fix this, we start a quick heal of the worldstate automatically and once the fix is done we restart the block import.
After the detection of an invalid path
This feature can also heal a node that has been inconsistent for a long time, but it will take longer because there will be more nodes to heal. With this PR the healing will be done as soon as the problem is detected so there will not a lot to heal and it will be fast
Performed tests
Fixed Issue(s)
#4379
#4785
#4768
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog