TrieLog shipping prep #5317
Merged
TrieLog shipping prep #5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
garyschulte
force-pushed
the
zkbesu-707/accumulator-zero-reads
branch
4 times, most recently
from
8727fbf
to
7419e59
Compare
garyschulte
force-pushed
the
zkbesu-707/accumulator-zero-reads
branch
from
966aa5d
to
5ac40b7
Compare
garyschulte
force-pushed
the
zkbesu-707/accumulator-zero-reads
branch
from
3a0478c
to
924193a
Compare
|
macfarla
approved these changes
Apr 19, 2023
...eum/core/src/test/java/org/hyperledger/besu/ethereum/bonsai/trielog/TrieLogManagerTests.java
Outdated
Show resolved
Hide resolved
...n/java/org/hyperledger/besu/ethereum/bonsai/worldview/BonsaiWorldStateUpdateAccumulator.java
Outdated
Show resolved
Hide resolved
.../core/src/main/java/org/hyperledger/besu/ethereum/bonsai/trielog/AbstractTrieLogManager.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/test/java/org/hyperledger/besu/ethereum/bonsai/trielog/TrieLogLayerTests.java
Show resolved
Hide resolved
macfarla
approved these changes
Apr 19, 2023
Signed-off-by: garyschulte <[email protected]>
…ots from trielog generation Signed-off-by: garyschulte <[email protected]>
…ge as cleared Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
garyschulte
force-pushed
the
zkbesu-707/accumulator-zero-reads
branch
from
a9630ea
to
aba0b39
Compare
shemnon
reviewed
Apr 20, 2023
| var val = slotUpdate.getValue(); | ||
|
|
||
| if (val.getPrior() == null && val.getUpdated() == null) { | ||
| // by default do not persist empty reads to the trie log |
There was a problem hiding this comment.
We will need enough to prove absence when Verkle Tries happen. Something to keep in mind but I don't think now is the time to address it.
matkt
reviewed
Apr 20, 2023
| @@ -69,6 +71,10 @@ public synchronized void saveTrieLog( | |||
| try { | |||
| final TrieLogLayer trieLog = prepareTrieLog(forBlockHeader, localUpdater); | |||
| persistTrieLog(forBlockHeader, forWorldStateRootHash, trieLog, stateUpdater); | |||
|
|
|||
| // notify trie log added observers, synchronously | |||
| trieLogAddedObservers.forEach(o -> o.onTrieLogAdded(new TrieLogAddedEvent(trieLog))); | |||
There was a problem hiding this comment.
do we want to notify subscribers synchronously ?
There was a problem hiding this comment.
Besu's observer notification precedent is synchronous. I put this comment here to call out that we are conforming to that precedent, but this might be a good candidate for handling async here rather than in the observer itself. Since we don't have any observers yet, IMO it didn't warrant creating that behavior (yet?)
matkt
reviewed
Apr 20, 2023
| @@ -512,6 +502,10 @@ private void importIntoTrieLog(final TrieLogLayer layer, final Hash blockHash) { | |||
| newValue.getBalance(), | |||
| newValue.getStorageRoot(), | |||
| newValue.getCodeHash()); | |||
| if (oldValue == null && newValue == null) { | |||
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
* trielog save event, observer, test * add zero read slots to Accumulator storageToUpdate, omit zero read slots from trielog generation * add account zero reads, mark self-destructed accounts, code and storage as cleared Signed-off-by: garyschulte <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* trielog save event, observer, test * add zero read slots to Accumulator storageToUpdate, omit zero read slots from trielog generation * add account zero reads, mark self-destructed accounts, code and storage as cleared Signed-off-by: garyschulte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
prep bonsai for trielog shipping
add zero reads of slot storage and accounts to bonsai accumulator storageToUpdate and accountsToUpdate
Fixed Issue(s)
protocols-misc 707