Updating confusing --bonsai-maximum-back-layers-to-load option to --bonsai-historical-block-limit + remove deprecated snapshots config

[non-fungible-nelson]

PR description

Changed the mentioned flags. Alias used to keep backwards compatibility. Also removed now deprecated snapshots option.

Fixed Issue(s)

Ambiguity

[github-actions]

• I thought about documentation and added the doc-change-required label to this PR if updates are required.
• I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.
• I thought about the changelog and included a changelog update if required.

[non-fungible-nelson]

gotta love more red than green on a PR

[macfarla]

there is one unit test failing

java.lang.AssertionError: 
Expecting actual:
  "Invalid value for option '--bonsai-maximum-back-layers-to-load': 'ten' is not a long

To display full help:
besu [COMMAND] --help
"
to contain:
  "Invalid value for option '--bonsai-historical-block-limit': 'ten' is not a long" 
	at org.hyperledger.besu.cli.BesuCommandTest.parsesInvalidBonsaiTrieBonsaiHistoricalBlockLimit(BesuCommandTest.java:1912)

[macfarla]

there is one unit test failing

@non-fungible-nelson I believe PicoCLI is choosing the longest name to throw into that error message.

You could look at how host-whitelist is handled - it's a hidden alternative (separate option) to host-allowlist - but then you have to handle the case where both are supplied

also if you don't hide that option name it will still display in the help ->

      --bonsai-historical-block-limit,
        --bonsai-maximum-back-layers-to-load=<LONG>
                             Limit of historical layers that can be loaded with
                               BONSAI (default: 512).

Alternatively - if we don't mind users still seeing the old name, you could just remove that test - it's not critical

[non-fungible-nelson]

I think seeing both is OK if you're querying for help directly. As long as we are clear in the docs and it supplies to the client correctly.