Use retry switching peer for world state download tasks #5508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
|
matkt
reviewed
May 29, 2023
| super( | ||
| ethContext, | ||
| metricsSystem, | ||
| data -> data.proofs().isEmpty() && data.slots().isEmpty(), |
There was a problem hiding this comment.
A bad peer will be a peer with this kind of result
I’m not sure you are checking if the response is like that in order to switch to another peer
There was a problem hiding this comment.
check this other PR #5509, that checks and records the empty response in the AbstractRetryingPeerTask
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
…e-retry-switching-peer # Conflicts: # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/RetryingGetAccountRangeFromPeerTask.java # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/RetryingGetBytecodeFromPeerTask.java # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/RetryingGetStorageRangeFromPeerTask.java # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/RetryingGetTrieNodeFromPeerTask.java # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/task/RetryingGetNodeDataFromPeerTask.java
…e-retry-switching-peer
Signed-off-by: Fabio Di Fabio <[email protected]>
…e-retry-switching-peer
Signed-off-by: Fabio Di Fabio <[email protected]>
siladu
reviewed
Jun 1, 2023
| @@ -155,7 +166,8 @@ public void completesWhenPeersAreTemporarilyUnavailable() | |||
| final T requestedData = generateDataToBeRequested(); | |||
|
|
|||
| // Execute task and wait for response | |||
| final EthTask<T> task = createTask(requestedData); | |||
| // +2 is required for switching peers tasks where the max retries = number of peers | |||
| @@ -320,7 +320,9 @@ public Stream<EthPeer> streamAvailablePeers() { | |||
| } | |||
|
|
|||
| public Stream<EthPeer> streamBestPeers() { | |||
| return streamAvailablePeers().sorted(getBestChainComparator().reversed()); | |||
| return streamAvailablePeers() | |||
| .filter(EthPeer::isFullyValidated) | |||
|
Just a question. A peer that is useless for the worldstate part may not be for the blockchain part. Is there not a risk of losing valid nodes for a certain type of data by marking useless when it could still help us. For example Besu and Nethermind which do not provide Snapsync data but remain valid for the blockchain. Should not have a more complex notion of useless ? |
|
testing currently the PR with my snapsync boost feature |
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
|
Blocked by #6609 - without that we would disconnect peers, because we are trying peers that do not serve snap data. |
|
@fab-10 Closing this, reopen if think we still need it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Built on top of #5509, so please check it first. Link to only see diff again #5509
With this PR all the world state download tasks used by snap sync are updated to use the retry switching peer strategy, to reduce the chance that we keep sending requests to the same bad peer.
relates to #5415 and #5271