SnapServer using FlatDB Strategy #5887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged
garyschulte
force-pushed
the
feature/snap-sync-server
branch
2 times, most recently
from
ba392d5
to
f0c145b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/SnapServer.java
Fixed
Show fixed
Hide fixed
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/SnapServer.java
Fixed
Show fixed
Hide fixed
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/SnapServer.java
Fixed
Show fixed
Hide fixed
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/SnapServer.java
Fixed
Show fixed
Hide fixed
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/SnapServer.java
Fixed
Show fixed
Hide fixed
garyschulte
force-pushed
the
feature/snap-sync-server
branch
from
f0c145b
to
8179a31
Compare
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/SnapServer.java
Fixed
Show fixed
Hide fixed
garyschulte
force-pushed
the
feature/snap-sync-server
branch
from
6098087
to
30dfc08
Compare
matkt
reviewed
Sep 25, 2023
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/SnapServer.java
Outdated
Show resolved
Hide resolved
garyschulte
force-pushed
the
feature/snap-sync-server
branch
from
c32a98e
to
a2ee5a7
Compare
|
blocked by #5889 |
garyschulte
force-pushed
the
feature/snap-sync-server
branch
5 times, most recently
from
a71bac6
to
6790640
Compare
garyschulte
force-pushed
the
feature/snap-sync-server
branch
from
6790640
to
487095a
Compare
matkt
reviewed
Oct 4, 2023
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/snap/SnapServer.java
Outdated
Show resolved
Hide resolved
garyschulte
force-pushed
the
feature/snap-sync-server
branch
from
6475e4e
to
26fd65c
Compare
garyschulte
force-pushed
the
feature/snap-sync-server
branch
4 times, most recently
from
05f5fb6
to
7ee0869
Compare
garyschulte
force-pushed
the
feature/snap-sync-server
branch
7 times, most recently
from
1c6d8b0
to
035e23b
Compare
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
… broken Signed-off-by: garyschulte <[email protected]>
skeltal implementation of getTrieNodes message Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
…, add getByteCodes test for SnapServer Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
…omments for CompactEncoding bugfix getStorageByRootHash to only return head worldstate if the supplied optional rootHash is empty Signed-off-by: garyschulte <[email protected]>
rework storage iteration and last key proving added test for interrupted storage range requests send proofs without leaf nodes, do not fail single node proofs on ordering. Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
fix contract test fixtures Signed-off-by: garyschulte <[email protected]>
… and worldstate provider Signed-off-by: garyschulte <[email protected]>
…art/stop semantics Signed-off-by: garyschulte <[email protected]>
warn if snap server is created without reference to sync status remove proof without leaf value do not send empty storage ranges, only a left side proof of startkeyhash if the range is empty Signed-off-by: garyschulte <[email protected]>
* bump max header limit to 512, as 192 was arbitrarily low * add timings and reponse sizes to debug logs in SnapServer * fudge factor hack for response size limits in snapserver * adjust snapserver unit tests, send no keys or proofs if storage range is empty * prevent potential stampede of worldstate caching from snap server by marking getStorageRootByHash synchronized Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
…rage range Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
garyschulte
force-pushed
the
feature/snap-sync-server
branch
from
8407b9e
to
215cd0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
PR to implement SnapServer using FlatDB Strategy.
marked Draft until we have code storage by code hash rolled out.
Fixed Issue(s)
#3165