Add Cancun GraphQL fields #5923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the fields for Blobs into the GraphQL service. Signed-off-by: Danno Ferrin <[email protected]>
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...in/java/org/hyperledger/besu/ethereum/api/graphql/internal/pojoadapter/BlockAdapterBase.java
Fixed
Show fixed
Hide fixed
...in/java/org/hyperledger/besu/ethereum/api/graphql/internal/pojoadapter/BlockAdapterBase.java
Fixed
Show fixed
Hide fixed
.../java/org/hyperledger/besu/ethereum/api/graphql/internal/pojoadapter/TransactionAdapter.java
Fixed
Show fixed
Hide fixed
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
macfarla
reviewed
Sep 22, 2023
| @@ -199,6 +199,14 @@ type Block { | |||
| withdrawals are unavailable for this block, this field will be null. | |||
| """ | |||
| withdrawals: [Withdrawal!] | |||
|
|
|||
| """BlobGasUsed is the total amount of gas used by the transactions.""" | |||
There was a problem hiding this comment.
Suggested change
| """BlobGasUsed is the total amount of gas used by the transactions.""" | |
| """BlobGasUsed is the total amount of blob gas used by the transactions.""" |
There was a problem hiding this comment.
This is a cut and paste from the execution-apis repo, it should be fixed there first - https://github.com/ethereum/execution-apis/pull/468/files#diff-a44507d2ad2482bb3ed863208b9e1e0393069edfdbd686593bac598901f36770R804
.../api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/TransactionDataFetcherTest.java
Outdated
Show resolved
Hide resolved
macfarla
approved these changes
Sep 26, 2023
Signed-off-by: Danno Ferrin <[email protected]>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 10, 2023
Add the fields for Blobs into the GraphQL service. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Justin Florentine <[email protected]>
NickSneo
pushed a commit
to NickSneo/besu
that referenced
this pull request
Nov 12, 2023
Add the fields for Blobs into the GraphQL service. Signed-off-by: Danno Ferrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add the fields for Blobs into the GraphQL service.
Fixed Issue(s)