Support Version Rollbacks for RocksDB

[RatanRSur]

PR description

Primary:

This fixes an issue where rolling back the default database version could cause an error. It's important that the loading logic depends only on the database version so we can have full control. It's still fine to set auxiliary properties like isSegmentIsolationSupported as we go through the creation process.

Other:

Extend the plugin interface with Closeable

Fixed Issue(s)

[ryjones]

@RatanRSur could you please squash this into one commit and rebase on the tip of master? thanks

[RatanRSur]

Hey @ryjones, I believe @shemnon reached out and addressed this?

[ryjones]

Hey @ryjones, I believe @shemnon reached out and addressed this?

correct - I'm wrong, ignore me

[RatanRSur]

No worries! I believe that once you mark your comment as resolved, the change requested block will be lifted

[ryjones]

Sorry for the turbulence!

[ryjones]

Ignore me

[RatanRSur]

One more thing - can you withdraw your approval? We use those for signaling that someone has done a complete code review and thinks the changes are ready to be merged.

[ryjones]

One more thing - can you withdraw your approval? We use those for signaling that someone has done a complete code review and thinks the changes are ready to be merged.

Tell me what to click and where. I can't find an option for me to dismiss my own review

[RatanRSur]

I had to look it up myself! Turns out I can do it myself but so that you know:

Where it says 1 approval, the drop down will have your name. On the right side overflow menu there's a Dismiss Review button

I clicked without understanding

[CjHare]

The cause of Privacy AT failures are the RocksDBKeyValuePrivacyFactory attempting to use the same RocksDB file as the RocksDBKeyValueFactory.
Overriding of the storage path to include an additional path especially for the Privacy RocksDB file (yes, there are currently two RocksDB databases)

I've pre-emptively approved this, because as soon as you get those Privacy ATs passing (which could be done by accepting the suggested commits) then the PR is good to go!