Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase scope of reference tests #6287

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Dec 12, 2023

PR description

Add new forks to transaction tests, add bad rlp to rlp ref tests.

Fixed Issue(s)

Add new forks to transaction tests, add bad rlp to rlp ref tests.

Signed-off-by: Danno Ferrin <[email protected]>
@shemnon shemnon requested a review from diega December 12, 2023 22:20
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Copy link
Contributor

@diega diega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great finding on this missing cases

@macfarla macfarla merged commit 7770f96 into hyperledger:main Dec 13, 2023
19 checks passed
gfukushima pushed a commit to gfukushima/besu that referenced this pull request Dec 15, 2023
Add new forks to transaction tests, add bad rlp to rlp ref tests.

Signed-off-by: Danno Ferrin <[email protected]>
gfukushima pushed a commit to gfukushima/besu that referenced this pull request Dec 15, 2023
Add new forks to transaction tests, add bad rlp to rlp ref tests.

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
jflo pushed a commit to jflo/besu that referenced this pull request Dec 18, 2023
Add new forks to transaction tests, add bad rlp to rlp ref tests.

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: jflo <[email protected]>
jflo pushed a commit to jflo/besu that referenced this pull request Dec 18, 2023
Add new forks to transaction tests, add bad rlp to rlp ref tests.

Signed-off-by: Danno Ferrin <[email protected]>
jflo pushed a commit to jflo/besu that referenced this pull request Dec 18, 2023
Add new forks to transaction tests, add bad rlp to rlp ref tests.

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: jflo <[email protected]>
jflo added a commit that referenced this pull request Dec 19, 2023
* Increase scope of reference tests (#6287)

Add new forks to transaction tests, add bad rlp to rlp ref tests.

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: jflo <[email protected]>

* Add trace to web socket JSON/RPC responses (#6285)

* Add trace to web socket JSON/RPC responses

Signed-off-by: Matthew Whitehead <[email protected]>

* Don't throw runtime exception if we can't parse JSON for trace

Signed-off-by: Matthew Whitehead <[email protected]>

---------

Signed-off-by: Matthew Whitehead <[email protected]>
Signed-off-by: jflo <[email protected]>

* [MINOR] Include Enode URL in error message if parsing exception (#6288)

* include the actual Enode URL in the error message if IP can't be resolved

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: jflo <[email protected]>

* Execute the terminatedImmediately method only once (#6284)

Signed-off-by: David Lutzardo <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: jflo <[email protected]>

* move forest class to a specific package (#6293)

cleaning up the worldstate section, moving and renaming everything that is forest into a specific package in order to clarify the difference between Bonsai and Forest in the code.

---------

Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: matkt <[email protected]>
Signed-off-by: jflo <[email protected]>

* removed vintage junit dependency (#6296)

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: jflo <[email protected]>

* updated cli and chainimport/export tests to junit 5 (#6281)

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: jflo <[email protected]>

* [MINOR] CLI Subcommands migrate to junit 5 (#6282)

* updated cli and chainimport/export tests to junit 5

Signed-off-by: Sally MacFarlane <[email protected]>

* subcommands and besucommand test to junit5

Signed-off-by: Sally MacFarlane <[email protected]>

* removed duplicate line

Signed-off-by: Sally MacFarlane <[email protected]>

* removed vintage junit dep

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Co-authored-by: Fabio Di Fabio <[email protected]>
Signed-off-by: jflo <[email protected]>

* [MINOR] add genesis file name to config overview (#6297)

* add genesis file name to config overview

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: jflo <[email protected]>

* create trie package for bonsai and forest (#6300)

Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: matkt <[email protected]>
Signed-off-by: jflo <[email protected]>

* [MINOR] More cli tests to junit 5 (#6283)

* more CLI and services tests to junit5

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Co-authored-by: Fabio Di Fabio <[email protected]>
Signed-off-by: jflo <[email protected]>

* Update Gradle plugins and replace unmaintained license plugin (#6275)

Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: jflo <[email protected]>

* Quick fix to avoid a tight loop when processing added blocks in txpool (#6309)

Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: jflo <[email protected]>

* uprev to version 23.10.3-RC4

Signed-off-by: jflo <[email protected]>

* mark deleted slot during clear storage step

Signed-off-by: Karim Taam <[email protected]>

---------

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: jflo <[email protected]>
Signed-off-by: Matthew Whitehead <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: David Lutzardo <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: matkt <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Co-authored-by: Danno Ferrin <[email protected]>
Co-authored-by: Matt Whitehead <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Co-authored-by: David Lutzardo <[email protected]>
Co-authored-by: Karim TAAM <[email protected]>
Co-authored-by: Fabio Di Fabio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants