Add a sender cache to Transaction #6375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ameziane H <[email protected]>
|
Signed-off-by: Ameziane H <[email protected]>
Signed-off-by: Ameziane H <[email protected]>
fab-10
reviewed
Jan 9, 2024
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Transaction.java
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Transaction.java
Outdated
Show resolved
Hide resolved
…lel and asynchronously Signed-off-by: Ameziane H <[email protected]>
Signed-off-by: Ameziane H <[email protected]>
fab-10
approved these changes
Jan 12, 2024
.../hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/AbstractEngineNewPayload.java
Show resolved
Hide resolved
Signed-off-by: Ameziane H <[email protected]>
fab-10
reviewed
Jan 17, 2024
.../hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/AbstractEngineNewPayload.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ameziane H <[email protected]>
fab-10
reviewed
Jan 18, 2024
.../hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/AbstractEngineNewPayload.java
Show resolved
Hide resolved
Signed-off-by: Ameziane H <[email protected]>
Signed-off-by: Ameziane H <[email protected]>
fab-10
approved these changes
Jan 19, 2024
… to 4 Signed-off-by: Ameziane H <[email protected]>
Signed-off-by: Ameziane H <[email protected]>
Signed-off-by: Ameziane H <[email protected]>
Signed-off-by: ahamlat <[email protected]>
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Transaction.java
Show resolved
Hide resolved
Signed-off-by: Ameziane H <[email protected]>
…ransaction.java Signed-off-by: Ameziane H <[email protected]>
fab-10
approved these changes
Feb 7, 2024
.../hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/AbstractEngineNewPayload.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ameziane H <[email protected]>
…sonrpc/internal/methods/engine/AbstractEngineNewPayload.java Co-authored-by: Fabio Di Fabio <[email protected]> Signed-off-by: ahamlat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR will create a new cache within the Transaction class to house all computed senders for their respective transaction hashes.
When receiving the newPayload call, it calculates asynchronously and in parallel all the transaction hashes and senders.
This PR is expected to improve block processing time, given that either the transaction sender is determined when Besu fills its transaction pool or with the asynchronous tasks.
The cache memory footprint
The cache is defined with this pair hash -> address, for 100_000 entries, it consumes currently less than 20 MiB.
We can find below the CPU profiling with and without this PR.
Without this PR
With this PR
We can notice also an improvement in terms of block processing time