Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Mockito #6397

Merged
merged 11 commits into from
Jan 15, 2024
Merged

Upgrade Mockito #6397

merged 11 commits into from
Jan 15, 2024

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Jan 12, 2024 •
edited
Loading

PR description

Upgrade Mockito to 5.8.0, that is a breaking change, and requires some code changes, in particular to avoid spying on maps.

Fixed Issue(s)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2024 •
edited by fab-10
Loading

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@fab-10 fab-10 marked this pull request as ready for review January 15, 2024 09:16
@fab-10 fab-10 enabled auto-merge (squash) January 15, 2024 09:17
@fab-10 fab-10 merged commit 724e3d0 into hyperledger:main Jan 15, 2024
17 of 18 checks passed
@fab-10 fab-10 deleted the upgrade-mockito branch January 16, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fab-10 @macfarla