Adding engine_getPayloadV4 and engine_newPayloadV4 #6783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucassaldanha
force-pushed
the
newPayloadV4
branch
from
66451f1
to
bd2f6cc
Compare
jflo
approved these changes
Mar 21, 2024
siladu
reviewed
Mar 22, 2024
| @@ -14,7 +14,7 @@ | |||
| "londonBlock":0, | |||
| "terminalTotalDifficulty":0, | |||
| "cancunTime":0, | |||
| "experimentalEipsTime":20, | |||
| "pragueTime":0, | |||
There was a problem hiding this comment.
Suggested change
| "pragueTime":0, | |
| "pragueTime":20, |
I think this might still want to be 20 because the point of these tests is to test the transition from cancun -> prague.
Hopefully that'll fix your AT failures, but that might be wishful thinking :)
There was a problem hiding this comment.
There were a couple of other things I had to fix, but yeah, this was the one that made me spend an hour braking my brain!
| @@ -63,7 +63,6 @@ public JsonRpcResponse syncResponse(final JsonRpcRequestContext requestContext) | |||
| .filter(e -> e.getMethodName().startsWith("engine_")) | |||
| .filter(e -> !e.equals(ENGINE_EXCHANGE_CAPABILITIES)) | |||
| .filter(e -> !e.equals(ENGINE_PREPARE_PAYLOAD_DEBUG)) | |||
| .filter(e -> !e.getMethodName().endsWith("6110")) | |||
There was a problem hiding this comment.
Should pre-prague Besu advertise that it has engine_*V4 available yet 🤔 ?
There was a problem hiding this comment.
They will be filtered out at ExecutionEngineJsonRpcMethods if we are not in Prague.
CHANGELOG.md
Outdated
| @@ -442,7 +442,8 @@ https://hyperledger.jfrog.io/artifactory/besu-binaries/besu/23.4.4/besu-23.4.4.z | |||
| - Early access - layered transaction pool implementation [#5290](https://github.com/hyperledger/besu/pull/5290) | |||
| - New RPC method `debug_getRawReceipts` [#5476](https://github.com/hyperledger/besu/pull/5476) | |||
| - Add TrieLogFactory plugin support [#5440](https://github.com/hyperledger/besu/pull/5440) | |||
| - Ignore `min-block-occupancy-ratio` option when on PoS networks, since in some cases, it prevents to have full blocks even if enough transactions are present [#5491](https://github.com/hyperledger/besu/pull/5491) | |||
| - Ignore `min-block-occupancy-ratio` option when on PoS networks, since in some cases, it prevents to have full blocks even if enough transactions are present [#5491](https://github.com/hyperledger/besu/pull/5491) | |||
| - Added engine_newPayloadV4 and engine_getPayloadV4 methods | |||
There was a problem hiding this comment.
This should be way up at the top of the changelog :)
lucassaldanha
force-pushed
the
newPayloadV4
branch
3 times, most recently
from
499ca2a
to
9f01436
Compare
Signed-off-by: Lucas Saldanha <[email protected]>
Signed-off-by: Lucas Saldanha <[email protected]>
Signed-off-by: Lucas Saldanha <[email protected]>
Signed-off-by: Lucas Saldanha <[email protected]>
lucassaldanha
force-pushed
the
newPayloadV4
branch
from
9f01436
to
01944bb
Compare
Signed-off-by: Lucas Saldanha <[email protected]>
|
|
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Mar 26, 2024
Moved engine_newPayload6110 and engine_getPayload6110 to V4 Signed-off-by: Lucas Saldanha <[email protected]> Signed-off-by: Justin Florentine <[email protected]>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
Moved engine_newPayload6110 and engine_getPayload6110 to V4 Signed-off-by: Lucas Saldanha <[email protected]> Signed-off-by: amsmota <[email protected]>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
Moved engine_newPayload6110 and engine_getPayload6110 to V4 Signed-off-by: Lucas Saldanha <[email protected]> Signed-off-by: amsmota <[email protected]>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
Moved engine_newPayload6110 and engine_getPayload6110 to V4 Signed-off-by: Lucas Saldanha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The Engine API spec has been updated with Prague (https://github.com/ethereum/execution-apis/blob/main/src/engine/prague.md). To help test the integration between CL and EL for EIP-6110 and EIP-7002, I have started working to move these methods from experimental into V4 (conditional to Prague activation).
At the moment, only deposit receipts are supported. I am adding support for validator exits as well. I can do it as a separate PR if it makes it easier to review etc. Just let me know.
Fixed Issue(s)
N/A
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Most advanced CI tests are deferred until PR approval, but you could:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests