Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to DefaultBlockchain to get TPS and Mgas/s #7105

Merged
merged 7 commits into from
May 31, 2024

Conversation

ahamlat
Copy link
Contributor

@ahamlat ahamlat commented May 15, 2024

PR description

This PR creates two new prometheus counters gasUsedCounter and numberOfTransactionsCounter.
These new counters will help to create graphs on Transactions per second and Gas used per second.

We can see below the result on Ethereum Mainnet, where the throughput is around 1.26 mgas/s and TPS is slightly less than 14 transactions per second.

image

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@ahamlat ahamlat marked this pull request as ready for review May 20, 2024 13:24
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prob worth a changelog entry

@macfarla macfarla enabled auto-merge (squash) May 31, 2024 03:04
@macfarla macfarla merged commit b0823c4 into hyperledger:main May 31, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants