feat: Expose set finalized/safe block in plugin api BlockchainService #7382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vice Signed-off-by: Usman Saleem <[email protected]>
…ainservice_finalized_block Signed-off-by: Usman Saleem <[email protected]>
fab-10
approved these changes
Jul 26, 2024
…ainservice_finalized_block Signed-off-by: Usman Saleem <[email protected]>
…ainservice_finalized_block Signed-off-by: Usman Saleem <[email protected]>
Signed-off-by: Usman Saleem <[email protected]>
usmansaleem
changed the title
Signed-off-by: Usman Saleem <[email protected]>
jframe
reviewed
Jul 30, 2024
| * @param blockHash Hash of the finalized block | ||
| * @throws UnsupportedOperationException if the network is not a POA network | ||
| */ | ||
| void setFinalizedBlock(Hash blockHash); |
There was a problem hiding this comment.
We also need the setSafeBlock method
| @@ -135,6 +142,17 @@ public Optional<Hash> getFinalizedBlock() { | |||
| return blockchain.getFinalized(); | |||
| } | |||
|
|
|||
| @Override | |||
| public void setFinalizedBlock(final Hash blockHash) { | |||
| if (genesisConfigOptionsSupplier != null) { | |||
There was a problem hiding this comment.
Just checking the genesis isn't going to work for chains that transition to POS.
You could use the protocolSchedule to check the chain is POS for given blockHash by doing something like
protocolSchedule.getByBlockHeader(blockchain.getBlockHeader(blockHash).get()).isPoS()
Signed-off-by: Usman Saleem <[email protected]>
…ainservice_finalized_block Signed-off-by: Usman Saleem <[email protected]>
Signed-off-by: Usman Saleem <[email protected]>
Signed-off-by: Usman Saleem <[email protected]>
fab-10
approved these changes
Jul 30, 2024
fab-10
approved these changes
Jul 30, 2024
usmansaleem
changed the title
jframe
approved these changes
Jul 31, 2024
…ainservice_finalized_block Signed-off-by: Usman Saleem <[email protected]>
Signed-off-by: Usman Saleem <[email protected]>
Signed-off-by: Usman Saleem <[email protected]>
Signed-off-by: Usman Saleem <[email protected]>
jframe
reviewed
Jul 31, 2024
|
|
||
| @Test | ||
| @DisplayName("Calling updateFinalizedBlockV1 will set finalized block") | ||
| public void canUpdateFinalizedBlock() throws IOException { |
There was a problem hiding this comment.
Should also test the updateSafeBlock method
Signed-off-by: Usman Saleem <[email protected]>
…ainservice_finalized_block Signed-off-by: Usman Saleem <[email protected]>
fab-10
approved these changes
Jul 31, 2024
…ainservice_finalized_block Signed-off-by: Usman Saleem <[email protected]>
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
…hyperledger#7382) * feat: Expose set finalized and safe block in plugin-api BlockchainService * check for poa network before setting finalized block * changelog * Add BlockchainService set finalized acceptance test --------- Signed-off-by: Usman Saleem <[email protected]> Signed-off-by: gconnect <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
feat: Expose set finalized/safe block in plugin api BlockchainService. This method can be used by plugins to set finalized/safe block for a POA network (such as QBFT, IBFT and Clique).
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests