Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVMTool Docker Support #7430

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Aug 6, 2024

PR description

A few fixes that re-enable docker support for evm tool

  • evmtool is the entrypoint
  • turn off some noisy logging
  • ensure EOF respects the create flag

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

shemnon and others added 2 commits August 6, 2024 09:42
A few fixes that re-enable docker support for evm tool
* evmtool is the entrypoint
* turn off some noisy logging
* ensure EOF respects the create flag

Signed-off-by: Danno Ferrin (shemnon) <[email protected]>
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shemnon shemnon merged commit a92fdbb into hyperledger:main Aug 7, 2024
40 checks passed
gconnect pushed a commit to gconnect/besu that referenced this pull request Aug 26, 2024
A few fixes that re-enable docker support for evm tool
* evmtool is the entrypoint
* turn off some noisy logging
* ensure EOF respects the create flag

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: gconnect <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants