Add 'inbound' field to admin_peers JSON-RPC Call #7461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 7suyash7 <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
macfarla
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
LGTM
example output
{"version":"0x5","name":"Geth/v1.13.14-stable-2ecaf439/linux-amd64/go1.22.2","caps":["eth/68","snap/1"],"network":{"localAddress":"172.16.0.2:63518","remoteAddress":"15.204.46.163:30303","inbound":false},"port":"0x0","id":"0xb91040a620d71a5d16431600e396991191b2f079452628a7722c1a14f8dbecdab00a1ea64e354c65ba4b58d67b9afeed913a6b8191fb4108498e10baa17d84c7","protocols":{"eth":{"difficulty":"0xc70d815d562d3cfa955","head":"0x39e83ddfc08b7268950fcf2903f3e8b9c392992204e2faa831d1779273b010d1","version":68}},"enode":"enode://b91040a620d71a5d16431600e396991191b2f079452628a7722c1a14f8dbecdab00a1ea64e354c65ba4b58d67b9afeed913a6b8191fb4108498e10baa17d84c7@15.204.46.163:30303"}
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
* Add 'inbound' field to admin_peers JSON-RPC Call Signed-off-by: 7suyash7 <[email protected]> * added changelog entry Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: 7suyash7 <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: gconnect <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an 'inbound' field to the network information returned by the admin_peers JSON-RPC Call.
Resolves #7436