Correctly release txpool save and restore lock in case of exceptions #7473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
force-pushed
the
fix-release-disk-access-lock-on-tx-restore
branch
from
4cbb5ff
to
72a8409
Compare
garyschulte
approved these changes
Aug 16, 2024
cloudspores
pushed a commit
to cloudspores/besu
that referenced
this pull request
Aug 23, 2024
…yperledger#7473) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Ade Lucas <[email protected]>
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
…yperledger#7473) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: gconnect <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The disk access lock used when saving or restoring the txpool from disk, was not released in case of an exception, with the effect of stalling the sync
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests