Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGELOG] remove docs updates from changelog #7562

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Sep 3, 2024

PR description

Besu docs used to be part of besu repo.
This is why documentation updates are listed in the besu changelog for older versions of besu
This PR removes those entries from the changelog - no longer relevant and also containing links that are likely to be or become out of date.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla changed the title remove docs updates from changelog [CHANGELOG] remove docs updates from changelog Sep 3, 2024
@macfarla macfarla marked this pull request as ready for review September 3, 2024 00:40
@macfarla
Copy link
Contributor Author

macfarla commented Sep 3, 2024

Think this is a better option than keeping links up to date as per #7558

We could go further and delete anything that's already been released - discussion in discord https://discord.gg/hyperledger

Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, probably worth adding a changelog entry describing the change

@macfarla macfarla enabled auto-merge (squash) September 4, 2024 01:34
@macfarla macfarla merged commit ffd23e1 into hyperledger:main Sep 4, 2024
40 checks passed
@macfarla macfarla deleted the remove-changelog-docs-changes branch September 16, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants