7311: Add feature toggle for enabling use of the peertask system where available #7633
+34
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e available Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…tantiation Signed-off-by: Matilda Clerke <[email protected]>
…en initializing PeerTaskFeatureToggle multiple times Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
macfarla
reviewed
Sep 18, 2024
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
macfarla
reviewed
Sep 18, 2024
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
macfarla
approved these changes
Sep 18, 2024
jframe
requested changes
Sep 18, 2024
besu/src/main/java/org/hyperledger/besu/cli/options/stable/P2PTLSConfigOptions.java
Outdated
Show resolved
Hide resolved
| * Temporary class to allow easy access to the PeerTask feature toggle. This class can be removed | ||
| * once we've properly tested the PeerTask system and want to enable it permanently | ||
| */ | ||
| public class PeerTaskFeatureToggle { |
There was a problem hiding this comment.
Don't think this class is needed, this value could go into the appropriate domain object and be used from there e.g. in SynchronizerConfiguration
There was a problem hiding this comment.
I wanted to avoid passing around yet another configuration object just for a temporary feature toggle
Signed-off-by: Matilda Clerke <[email protected]>
…peertask-system' into 7311-add-cli-feature-toggle-for-peertask-system
Signed-off-by: Matilda Clerke <[email protected]>
…stemEnabled in SynchronizerConfiguration Signed-off-by: Matilda Clerke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Adds a feature toggle to enable use of the peer task system. To be utilised in future PRs implementing usage of the peer task system