Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-7348:remove duplicate AcceptanceTestBase #7735

Closed
wants to merge 2 commits into from

Conversation

optimusprike
Copy link

@optimusprike optimusprike commented Oct 5, 2024

PR description

Fixed Issue(s)

fixes #7348

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Prakash Pudhucode <[email protected]>
macfarla
macfarla previously approved these changes Oct 8, 2024
@macfarla
Copy link
Contributor

macfarla commented Oct 8, 2024

@optimusprike looks good in principle but there's some compilation issues

@macfarla macfarla dismissed their stale review October 8, 2024 03:05

compile failed

@macfarla macfarla marked this pull request as draft October 9, 2024 03:36
@macfarla
Copy link
Contributor

@optimusprike are you still working on this/

@macfarla
Copy link
Contributor

closing due to inactivity

@macfarla macfarla closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the duplicated AcceptanceTestBase
2 participants