Check transaction types when replacing in the transaction pool. #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reject EIP-1559 for pre-fork blocks - accept both frontier and EIP-1559 transactions during phase 1 - reject frontier transactions after phase 2 is finalized Signed-off-by: Abdelhamid Bakhta <[email protected]>
Signed-off-by: Abdelhamid Bakhta <[email protected]>
Signed-off-by: Abdelhamid Bakhta <[email protected]>
shemnon
approved these changes
May 15, 2020
shemnon
pushed a commit
to shemnon/besu
that referenced
this pull request
May 23, 2020
…rledger#924) * Add checks on the replacement of a transaction in the pool: - reject EIP-1559 for pre-fork blocks - accept both frontier and EIP-1559 transactions during phase 1 - reject frontier transactions after phase 2 is finalized Signed-off-by: Abdelhamid Bakhta <[email protected]> Signed-off-by: Danno Ferrin <[email protected]>
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Jun 3, 2020
…rledger#924) * Add checks on the replacement of a transaction in the pool: - reject EIP-1559 for pre-fork blocks - accept both frontier and EIP-1559 transactions during phase 1 - reject frontier transactions after phase 2 is finalized Signed-off-by: Abdelhamid Bakhta <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add checks on the replacement of a transaction in the pool:
Fixed Issue(s)
fixes #923
Signed-off-by: Abdelhamid Bakhta [email protected]