Idemix MSP Folder Structure incompatible with what Fabric expects #303 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denyeart
reviewed
Jun 24, 2022
Comment on lines
-116
to
-117
| if val.CurveID == "" { | ||
| val.CurveID = idemix4.DefaultIdemixCurve |
There was a problem hiding this comment.
Don't we still have to handle the blank val.CurveID?
There was a problem hiding this comment.
that field is not needed anymore
Comment on lines
-23
to
-24
| // CurveID specifies the name of the Idemix curve to use, defaults to 'amcl.Fp256bn' | ||
| CurveID string `protobuf:"bytes,7,opt,name=curve_id,json=curveID" json:"curveID,omitempty"` |
There was a problem hiding this comment.
CurveID was recently added by Yacov, don't we need it?
There was a problem hiding this comment.
Yes, but we don't need this field. It is never used and does not offer any advantage at the current stage.
The SignerConfig struct here is just a copy of the same struct in the Idemix lib.
|
@denyeart , thanks for you feedback. Please, let me know if the answers to your questions make sense. |
denyeart
previously approved these changes
Jun 27, 2022
…erledger#303 Signed-off-by: Angelo De Caro <[email protected]>
…cts hyperledger#303 Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
denyeart
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Angelo De Caro [email protected]
Type of change
Description
Currently, Fabric-CA generates an Idemix MSP folder structure and file content that Fabric is not able to load.
Namely:
SignerConfigis encoded in json, Fabric expected protoRevocationPublicKeyandIdemixRevocationPublicKey.Additional details
Related issues
#303