-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Go to 1.17.x #3073
Comments
/integration/pluggable integration test fails on Go 1.17 when trying to compile the validation plugin with command: Turns out there are two dependencies that aren't compatible with Go 1.17:
github.com/cespare/xxhash/v2 has a fix, see: But, we can't pull in the latest prometheus that has the xxhash fix without also updating protobuf, which is an issue for etcd (being worked in #3117). For now we can do a replace in go.mod to update github.com/cespare/xxhash/v2.
The integration test failure reported in #3115 is:
It doesn't look like there is a fix in github.com/consensys/gnark-crypto yet, so we will either need to remove this dependency or see if that project can do a similar fix as was done in github.com/cespare/xxhash/v2. |
@ale-linux Could you look at the last issue above? |
I think that this fixes it. Let's see what the maintainers of gnark-crypto say. |
Update Go to 1.17.x in fabric and related repositories.
Prep PRs:
Fix build tags for Go 1.17 - #3070
Resolve Go 1.17 staticcheck issues for dependency projects - #3114
The text was updated successfully, but these errors were encountered: