Bump Go to 1.17.5 #3115
Merged
Bump Go to 1.17.5 #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
previously approved these changes
Dec 12, 2021
denyeart
force-pushed
the
go1.17.5
branch
2 times, most recently
from
b403052
to
8934a24
Compare
Closed
ale-linux
requested changes
Dec 15, 2021
There was a problem hiding this comment.
Tests pass now after bumping the dependencies. Note that we can't merge yet because we're using an untagged version of gnark-crypto
https://github.com/IBM/mathlib/blob/go1.17/go.mod#L6
We have a few options:
- wait till gnark-crypto cuts their release (the maintainer said it would be a matter of a few days)
- stick with the untagged version (I wouldn't recommend this)
@denyeart: your call
|
Thanks @ale-linux , let's wait for their release, converting this PR to Draft. |
|
@ale-linux Happy New Year! |
Bump Go to 1.17.5. Fix unit tests to work with Go 1.17.5. Update dependencies to work with Go 1.17. Signed-off-by: David Enyeart <[email protected]>
Signed-off-by: Alessandro Sorniotti <[email protected]>
|
Ale's commit resolves the final dependency issue with Go 1.17. |
ale-linux
approved these changes
Jan 13, 2022
|
LGTM - but I contributed so I won't merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump Go to 1.17.5.
Fix unit tests to work with Go 1.17.5.
Update dependencies to work with Go 1.17.
Resolves #3073
Signed-off-by: David Enyeart [email protected]