Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not close a.eventStream, rather handle closed batch dispatcher #183

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

peterbroadhurst
Copy link
Contributor

Fix for #182

@codecov-commenter
Copy link

Codecov Report

Merging #183 (2c82118) into main (d74a775) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   97.23%   97.10%   -0.14%     
==========================================
  Files          57       57              
  Lines        6811     6813       +2     
==========================================
- Hits         6623     6616       -7     
- Misses        144      150       +6     
- Partials       44       47       +3     
Impacted Files Coverage Δ
ethconnect/internal/events/eventstream.go 96.61% <0.00%> (-1.69%) ⬇️
ethconnect/internal/kafka/kafkabridge.go 96.00% <0.00%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74a775...2c82118. Read the comment docs.

@vdamle vdamle merged commit a115d6c into hyperledger:main Nov 23, 2021
@vdamle vdamle deleted the fix-182 branch November 23, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants