Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removing unneeded async from func #172

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: removing unneeded async from func #172

merged 1 commit into from
Oct 23, 2024

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Oct 9, 2024 •
edited
Loading

Description:

There was a func with an unneeded async, removing.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@coveralls
Copy link

coveralls commented Oct 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11475851651

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 42.668%
Totals Coverage Status
Change from base Build 11461349631: 0.0%
Covered Lines: 5479
Relevant Lines: 12841
💛 - Coveralls

@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/remove_async branch 5 times, most recently from 7a1f73e to 6449834 Compare October 23, 2024 08:14
@goncalo-frade-iohk
fix: removing unneeded async from func
807d3d5 
Signed-off-by: goncalo-frade-iohk <[email protected]>
@goncalo-frade-iohk goncalo-frade-iohk merged commit 807d3d5 into main Oct 23, 2024
4 checks passed
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/remove_async branch October 23, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

@elribonazo elribonazo Awaiting requested review from elribonazo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goncalo-frade-iohk @coveralls @yshyn-iohk