Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optin to websockets for the mediator live mode as an experiment,… #199

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Apr 24, 2024

Description:

Disabling mediator live mode by default and enabling it as an optional experiment developers must opt-in, VS being enabled by default

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

… now disabled by default

Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
@elribonazo elribonazo linked an issue Apr 24, 2024 that may be closed by this pull request
@elribonazo elribonazo marked this pull request as ready for review April 24, 2024 10:10
Copy link

github-actions bot commented Apr 24, 2024

Lines Statements Branches Functions
Coverage: 71%
71.45% (1860/2603) 57.64% (731/1268) 74.69% (558/747)

JUnit

Tests Skipped Failures Errors Time
413 2 💤 0 ❌ 0 🔥 1m 1s ⏱️

Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
@elribonazo elribonazo merged commit 5fe7f33 into master Apr 24, 2024
5 checks passed
@elribonazo elribonazo deleted the features/git-198 branch April 24, 2024 17:43
elribonazo added a commit that referenced this pull request May 2, 2024
#199)

Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
atala-dev added a commit that referenced this pull request May 7, 2024
# [5.1.0](v5.0.0...v5.1.0) (2024-05-07)

### Bug Fixes

*  Rename the documentation file accordingly. ([#204](#204)) ([b77230f](b77230f))
* add compliant dates not in ms, but in seconds. ([#206](#206)) ([a3fc2aa](a3fc2aa))
* Agent.createNewPrismDID to use derivationPath ([#158](#158)) ([18cd084](18cd084))
* ConnectionManager emit Messages ([#190](#190)) ([08097b6](08097b6))
* db cannot be created twice with the same name which crashes demos ([#193](#193)) ([e39193e](e39193e))
* e2e issues with latest websocket changes ([#200](#200)) ([70e885b](70e885b))
* issue with build script not replacing some files that have been … ([#191](#191)) ([94a37cf](94a37cf))
* optin to websockets for the mediator live mode as an experiment,… ([#199](#199)) ([2bf406c](2bf406c))
* prevent broken links to exist in order for docs site to build pr… ([#205](#205)) ([74ee7a1](74ee7a1))
* Removing the if condition in CI pipeline for release branches ([#179](#179)) ([a7bb2e8](a7bb2e8))
* rename prism-agent into edge-agent ([#203](#203)) ([ac1d162](ac1d162))
* type references are lost in the package. ([#202](#202)) ([6c0e5fc](6c0e5fc))
* updating references to Identus ([#197](#197)) ([63d6703](63d6703))
* wasm build folder change ([#186](#186)) ([f59f6c6](f59f6c6))

### Features

* Implementing JWT Credential revocation notification ([#184](#184)) ([09cd573](09cd573))
* updating Anoncreds to io fork ([#157](#157)) ([06b50c9](06b50c9))
atala-dev added a commit that referenced this pull request May 17, 2024
# [5.1.0](v5.0.0...v5.1.0) (2024-05-17)

### Bug Fixes

*  Rename the documentation file accordingly. ([#204](#204)) ([90c1f54](90c1f54))
* add compliant dates not in ms, but in seconds. ([#206](#206)) ([76f4f48](76f4f48))
* Agent.createNewPrismDID to use derivationPath ([#158](#158)) ([06bc2cc](06bc2cc))
* Compatibility issues with osx and unix platforms around the sed ([#217](#217)) ([0b36372](0b36372))
* ConnectionManager emit Messages ([#190](#190)) ([776e55a](776e55a))
* db cannot be created twice with the same name which crashes demos ([#193](#193)) ([27f771c](27f771c))
* e2e issues with latest websocket changes ([#200](#200)) ([969fc06](969fc06))
* issue with build script not replacing some files that have been … ([#191](#191)) ([c26f014](c26f014))
* optin to websockets for the mediator live mode as an experiment,… ([#199](#199)) ([950bc76](950bc76))
* prevent broken links to exist in order for docs site to build pr… ([#205](#205)) ([f33f029](f33f029))
* Removing the if condition in CI pipeline for release branches ([#179](#179)) ([a8c4ebc](a8c4ebc))
* rename prism-agent into edge-agent ([#203](#203)) ([2a1fa1e](2a1fa1e))
* type references are lost in the package. ([#202](#202)) ([86ea42e](86ea42e))
* updating references to Identus ([#197](#197)) ([8fcb792](8fcb792))
* wasm build folder change ([#186](#186)) ([11ad81f](11ad81f))

### Features

* Implementing JWT Credential revocation notification ([#184](#184)) ([9aa8b8b](9aa8b8b))
* updating Anoncreds to io fork ([#157](#157)) ([8987de2](8987de2))
yshyn-iohk pushed a commit that referenced this pull request Jul 20, 2024
# [6.0.0](v5.0.0...v6.0.0) (2024-07-20)

### Bug Fixes

*  Rename the documentation file accordingly. ([#204](#204)) ([90c1f54](90c1f54))
* add compliant dates not in ms, but in seconds. ([#206](#206)) ([76f4f48](76f4f48))
* add e2e tests for jwt revocation, sdk verification for jwt and anoncreds ([#244](#244)) ([5c2519b](5c2519b))
* add missing files in package to clean rxdb vulnerabilities to fix e2e  ([#233](#233)) ([8b4c9e8](8b4c9e8))
* Agent.createNewPrismDID to use derivationPath ([#158](#158)) ([06bc2cc](06bc2cc))
* attachment descriptor parameters ([#240](#240)) ([2391f01](2391f01))
* attachment encoding fallback base64 + base64url by default ([#239](#239)) ([78cd8f7](78cd8f7))
* build node wasm not bundled up ([#226](#226)) ([48e78e3](48e78e3))
* **Castor:** createPrismDID and resolveDID key id conflicts ([#243](#243)) ([5024818](5024818))
* Compatibility issues with osx and unix platforms around the sed ([#217](#217)) ([8287eed](8287eed))
* ConnectionManager emit Messages ([#190](#190)) ([776e55a](776e55a))
* create custom class to verify bitstring position more precisely. ([#234](#234)) ([255184b](255184b))
* db cannot be created twice with the same name which crashes demos ([#193](#193)) ([27f771c](27f771c))
* deprecate browser demos ([#221](#221)) ([a6f9bdb](a6f9bdb))
* e2e issues fix ([#236](#236)) ([12019b9](12019b9))
* e2e issues with latest websocket changes ([#200](#200)) ([969fc06](969fc06))
* escape the `<->` sequence to fix the build error in the identus-… ([#248](#248)) ([15cf694](15cf694))
* generate docs after releasing as we cannot access a package that… ([#255](#255)) ([70efa8b](70efa8b))
* issue with build script not replacing some files that have been … ([#191](#191)) ([c26f014](c26f014))
* jwe rust library for backup encryption not including the node wa… ([#237](#237)) ([b1177a6](b1177a6))
* Message properties body, createdTime, expiresTimePlus ([#232](#232)) ([cf7db9f](cf7db9f))
* moving to hyperledger namespace ([#245](#245)) ([2139a78](2139a78))
* optin to websockets for the mediator live mode as an experiment,… ([#199](#199)) ([950bc76](950bc76))
* prevent broken links to exist in order for docs site to build pr… ([#205](#205)) ([f33f029](f33f029))
* releasing to HL ([#253](#253)) ([ed0fdf3](ed0fdf3))
* remove typo in release pipeline ([#254](#254)) ([34597e1](34597e1))
* Removing the if condition in CI pipeline for release branches ([#179](#179)) ([a8c4ebc](a8c4ebc))
* rename prism-agent into edge-agent ([#203](#203)) ([2a1fa1e](2a1fa1e))
* rename references ([#218](#218)) ([7d79d6f](7d79d6f))
* type references are lost in the package. ([#202](#202)) ([86ea42e](86ea42e))
* update event callback argument type ([#216](#216)) ([ec92fcb](ec92fcb))
* updating references to Identus ([#197](#197)) ([8fcb792](8fcb792))
* using rust dependency for jwe ([#235](#235)) ([0a35296](0a35296))
* wasm build folder change ([#186](#186)) ([11ad81f](11ad81f))

### Features

* add sdk jwt revocation verification ([#231](#231)) ([115c2c6](115c2c6))
* Backup and Restore ([#215](#215)) ([bf15325](bf15325))
* Implement sd+jwt for issuance and verification flows with cloud agent ([#228](#228)) ([a8c0b21](a8c0b21))
* Implementing JWT Credential revocation notification ([#184](#184)) ([9aa8b8b](9aa8b8b))
* implementing SDK Verification Phase2 Anoncreds ([#219](#219)) ([e80549c](e80549c))
* updating Anoncreds to io fork ([#157](#157)) ([8987de2](8987de2))

### BREAKING CHANGES

* Pollux instance now requires to have Apollo first constructor parameter (used internally)
Deprecated internal function processJWTCredential, processAnoncredsCredential and extractCredentialFormatFromMessage. Internally, in order to process any type of credential offer just call pollux.processCredentialOffer instead. In order to extract the credentialFormat from a DIDComm message if available, use message.credentialFormat (will return known CredentialType or unknown) In order to extract the payload of whatever DIDComm message, use message.payload which will decode it into the right object instance
JWT class now needs apollo and castor in constructor as they now instantiate from JWTCore (used internally)
Derivable Private key is not deriving using the derivationPath as a string not the DerivationPath class (used internally)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to opt-in or opt-out of the mediator live mode.
2 participants