fix: anoncreds rust build failing, enable bulk-memory c flag on compilation #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elribonazo
changed the title
…ling Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
elribonazo
force-pushed
the
feature/wasm-anoncreds-c-args
branch
from
11930ec
to
56bf1a4
Compare
elribonazo
requested review from
FabioPinheiro,
curtis-h,
amagyar-iohk and
yshyn-iohk
|
Pull Request Test Coverage Report for Build 11401832402Details
💛 - Coveralls |
FabioPinheiro
approved these changes
Oct 18, 2024
curtis-h
approved these changes
Oct 18, 2024
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
elribonazo
force-pushed
the
feature/wasm-anoncreds-c-args
branch
from
0447958
to
65aaf5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
New issue pops up recently https://github.com/hyperledger/identus-edge-agent-sdk-ts/actions/runs/11400371106, we now require +bulk-memory C flag while compiling anoncreds.
Reproduced the issue easily in local and this change fixes the issue.