Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding esbuild also as optional missing dependency #324

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elribonazo
Copy link
Contributor

Description:

Adding this change by default in the SDK will allow me to run a smooth demo.
During the development of the demo I was missing something and I found out that in our SDK, after parsing a OOB message we stored it but didn't emit the new message event.

This directly affects how people use the code, is needed to make the Hyperledger workshop smoother and not have people build the SDK from source!

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@elribonazo elribonazo requested a review from a team as a code owner November 5, 2024 21:02
fix: sending a didcomm message event when oob message is parsed

Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Copy link

github-actions bot commented Nov 5, 2024

Lines Statements Branches Functions
Coverage: 75%
76.08% (3633/4775) 66.49% (1665/2504) 80.29% (864/1076)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11692481940

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 72.553%

Totals Coverage Status
Change from base Build 11665870184: 0.004%
Covered Lines: 3524
Relevant Lines: 4648

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants