Fix primary selection after primary demotion (INDY-463) #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| checkViewNoForNodes(restNodes, 0) | ||
|
|
||
| primariesIdxs = getPrimaryNodesIdxs(restNodes) | ||
| assert restNodes[primariesIdxs[0]].name != master_node.name |
There was a problem hiding this comment.
Can we also check that pool is functional after this?
| logger.info("3. force view change 3 and check final viewNo") | ||
| ensure_view_change_complete(looper, restNodes) | ||
| viewNo3 = checkViewNoForNodes(restNodes) | ||
| assert viewNo3 == viewNo2 + 1 |
There was a problem hiding this comment.
How do we check that demoted primary is really skipped? Can we also check that pool is always functional after each view change?
…nto bugfix/fix_break_after_restart
…nto bugfix/fix_break_after_restart
ashcherbakov
approved these changes
Aug 28, 2017
lovesh
pushed a commit
that referenced
this pull request
Sep 6, 2017
* Node status tool base support * Improve node status tool support * Add OOP, renaming * Remove unsupported fields * Renaming * Add dynamic tests * Make node status tool safe * Fix primary selection after primary demotion (INDY-463) (#354) * modified rank routine, added test cases for primary demotion * fixed pep8 * fixed nodes oreder initialization * added checks that pool is functional after recofigurations * added additional view change to ensure original master is skipped * Merged hotfixes from stable for wallet and genesis pool transactions file migration and readme file. * Fix validator info tool (#365) * Don't add ip addresses, one-shot dump on start * Parameterize zmq network protocol * Cherry-pick cb7d068 8642be5 c37e835 from master
Toktar
pushed a commit
to Toktar/indy-plenum
that referenced
this pull request
Mar 1, 2021
* Node status tool base support * Improve node status tool support * Add OOP, renaming * Remove unsupported fields * Renaming * Add dynamic tests * Make node status tool safe * Fix primary selection after primary demotion (INDY-463) (hyperledger#354) * modified rank routine, added test cases for primary demotion * fixed pep8 * fixed nodes oreder initialization * added checks that pool is functional after recofigurations * added additional view change to ensure original master is skipped * Merged hotfixes from stable for wallet and genesis pool transactions file migration and readme file. * Fix validator info tool (hyperledger#365) * Don't add ip addresses, one-shot dump on start * Parameterize zmq network protocol * Cherry-pick cb7d068 8642be5 c37e835 from master Signed-off-by: Andrey Kononykhin <[email protected]> Sign-off-executed-by: toktar <[email protected]> Approved-at: h-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.