-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show 'missing genesis txn' help text only when 'connect test' is trigger #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovesh
suggested changes
Feb 20, 2017
plenum/cli/cli.py
Outdated
self.config.baseDir, | ||
self.githubUrl) | ||
self.print(msg) | ||
self.print("Node registry loaded.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the next 2 lines under if nodeReg
lovesh
approved these changes
Feb 20, 2017
lovesh
added a commit
that referenced
this pull request
Feb 21, 2017
* using the correct mechanism to choose random port * show node registry only when it is non empty and do not show the message of missing pool transaction file on startup (#68) * update help message for 'missing genesis txns file' * Revert "update help message for 'missing genesis txns file'" This reverts commit 4b15c4b. * update help message for 'missing genesis txns file' * show help info aoubt when trigger * Revert "show help info aoubt when trigger" This reverts commit 730e74c. * show 'missing genesis txn' help text only when 'connect test' is trigger * show node registery only if available
ghost
unassigned lovesh
Jun 29, 2017
Toktar
pushed a commit
to Toktar/indy-plenum
that referenced
this pull request
May 8, 2018
Toktar
pushed a commit
to Toktar/indy-plenum
that referenced
this pull request
Mar 1, 2021
* using the correct mechanism to choose random port * show node registry only when it is non empty and do not show the message of missing pool transaction file on startup (hyperledger#68) * update help message for 'missing genesis txns file' * Revert "update help message for 'missing genesis txns file'" This reverts commit 4b15c4b. * update help message for 'missing genesis txns file' * show help info aoubt when trigger * Revert "show help info aoubt when trigger" This reverts commit 730e74c. * show 'missing genesis txn' help text only when 'connect test' is trigger * show node registery only if available Signed-off-by: Lovesh Harchandani <[email protected]> Sign-off-executed-by: toktar <[email protected]> Approved-at: h-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.