refactor: Use ConstVec for instructions in Executable

crates/iroha_core/src/smartcontracts/isi/triggers/set.rs

@@ -19,6 +19,7 @@ use iroha_data_model::{
     query::error::FindError,
     transaction::WasmSmartContract,
 };
+use iroha_primitives::const_vec::ConstVec;
 use mv::{
     cell::{Block as CellBlock, Cell, Transaction as CellTransaction, View as CellView},
     storage::{
@@ -1012,7 +1013,7 @@ pub enum ExecutableRef {
     /// Loaded WASM
     Wasm(HashOf<WasmSmartContract>),
     /// Vector of ISI
-    Instructions(Vec<InstructionBox>),
+    Instructions(ConstVec<InstructionBox>),
 }
 
 impl core::fmt::Debug for ExecutableRef {

crates/iroha_data_model/src/block.rs

@@ -440,7 +440,7 @@ mod candidate {
             else {
                 return Err("Genesis transaction must contain instructions");
             };
-            let [InstructionBox::Upgrade(_)] = instructions_executor.as_slice() else {
+            let [InstructionBox::Upgrade(_)] = instructions_executor.as_ref() else {
                 return Err(
                     "First transaction must contain single `Upgrade` instruction to set executor",
                 );

crates/iroha_data_model/src/transaction.rs

@@ -30,6 +30,7 @@ use crate::{
 #[model]
 mod model {
     use getset::Getters;
+    use iroha_primitives::const_vec::ConstVec;
 
     use super::*;
     use crate::account::AccountId;
@@ -53,7 +54,7 @@ mod model {
     pub enum Executable {
         /// Ordered set of instructions.
         #[debug(fmt = "{_0:?}")]
-        Instructions(Vec<InstructionBox>),
+        Instructions(ConstVec<InstructionBox>),
         /// WebAssembly smartcontract
         Wasm(WasmSmartContract),
     }
@@ -182,7 +183,7 @@ mod model {
 
 impl<A: Instruction> FromIterator<A> for Executable {
     fn from_iter<T: IntoIterator<Item = A>>(iter: T) -> Self {
-        Self::Instructions(iter.into_iter().map(Into::into).collect())
+        Self::Instructions(iter.into_iter().map(Into::into).collect::<Vec<_>>().into())
     }
 }
 

crates/iroha_data_model/src/visit.rs

@@ -145,7 +145,7 @@ pub fn visit_transaction<V: Visit + ?Sized>(
     match transaction.instructions() {
         Executable::Wasm(wasm) => visitor.visit_wasm(authority, wasm),
         Executable::Instructions(instructions) => {
-            for isi in instructions {
+            for isi in instructions.as_ref() {
                 visitor.visit_instruction(authority, isi);
             }
         }

crates/iroha_executor/src/default.rs

@@ -63,7 +63,7 @@ pub fn visit_transaction<V: Validate + Visit + ?Sized>(
     match transaction.instructions() {
         Executable::Wasm(wasm) => executor.visit_wasm(authority, wasm),
         Executable::Instructions(instructions) => {
-            for isi in instructions {
+            for isi in instructions.as_ref() {
                 if executor.verdict().is_ok() {
                     executor.visit_instruction(authority, isi);
                 }

crates/iroha_schema_gen/src/lib.rs

@@ -192,6 +192,7 @@ types!(
     ConfigurationEventSet,
     ConstString,
     ConstVec<u8>,
+    ConstVec<InstructionBox>,
     CustomInstruction,
     CustomParameter,
     CustomParameterId,