Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiplication overflow detection for integer width > 64 bits #988

Merged
merged 16 commits into from
Sep 5, 2022
Merged

Multiplication overflow detection for integer width > 64 bits #988

merged 16 commits into from
Sep 5, 2022

Conversation

salaheldinsoliman
Copy link
Contributor

Signed-off-by: salaheldinsoliman [email protected]

@salaheldinsoliman
mul ovf > 64 bits
c143b20 
Signed-off-by: salaheldinsoliman <[email protected]>
seanyoung
seanyoung requested changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@seanyoung seanyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some nitpicks. Thanks @salaheldinsoliman

tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
src/emit/mod.rs Outdated Show resolved Hide resolved
src/emit/mod.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Show resolved Hide resolved
src/emit/mod.rs Outdated Show resolved Hide resolved
@LucasSte
Copy link
Contributor

Signed-off-by: salaheldinsoliman [email protected]

Please, update you PR summary with a brief description of your work.

LucasSte
LucasSte requested changes Aug 26, 2022
View reviewed changes
Cargo.toml Show resolved Hide resolved
src/emit/mod.rs Outdated Show resolved Hide resolved
src/emit/mod.rs Show resolved Hide resolved
src/emit/mod.rs Outdated Show resolved Hide resolved
src/emit/mod.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Show resolved Hide resolved
LucasSte
LucasSte requested changes Aug 30, 2022
View reviewed changes
src/emit/mod.rs Outdated Show resolved Hide resolved
src/emit/mod.rs Outdated Show resolved Hide resolved
src/emit/mod.rs Outdated Show resolved Hide resolved
src/emit/mod.rs Outdated Show resolved Hide resolved
src/emit/mod.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
xermicus
xermicus requested changes Aug 31, 2022
View reviewed changes
Cargo.toml Show resolved Hide resolved
src/emit/mod.rs Outdated Show resolved Hide resolved
src/emit/mod.rs Outdated Show resolved Hide resolved
seanyoung
seanyoung requested changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@seanyoung seanyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overflow tests should be run on Substrate too. Please copy them to the Substrate tests (will need minor modifications to make them work).

Thanks!

LucasSte
LucasSte requested changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@LucasSte LucasSte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is definitely coming together.

src/emit/mod.rs Outdated Show resolved Hide resolved
src/emit/mod.rs Outdated Show resolved Hide resolved
src/emit/mod.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
seanyoung
seanyoung requested changes Sep 1, 2022
View reviewed changes
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
tests/substrate_tests/expressions.rs Outdated Show resolved Hide resolved
tests/substrate_tests/expressions.rs Outdated Show resolved Hide resolved
tests/solana_tests/primitives.rs Outdated Show resolved Hide resolved
@salaheldinsoliman
Fix comments
88a6451 
Signed-off-by: salaheldinsoliman <[email protected]>
@salaheldinsoliman
test for whole bit range
fe3c238 
Signed-off-by: salaheldinsoliman <[email protected]>
@salaheldinsoliman
test for whole bit range
5810e65 
Signed-off-by: salaheldinsoliman <[email protected]>
@salaheldinsoliman
fix clippy
af33793 
Signed-off-by: salaheldinsoliman <[email protected]>
@salaheldinsoliman salaheldinsoliman removed the request for review from xermicus September 3, 2022 09:39
@salaheldinsoliman salaheldinsoliman requested review from LucasSte and seanyoung and removed request for LucasSte September 3, 2022 09:39
seanyoung
seanyoung approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@seanyoung seanyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seanyoung seanyoung merged commit a78b61a into hyperledger:main Sep 5, 2022
@xermicus xermicus mentioned this pull request Nov 4, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanyoung seanyoung seanyoung approved these changes

@xermicus xermicus xermicus approved these changes

@LucasSte LucasSte LucasSte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@salaheldinsoliman @LucasSte @seanyoung @xermicus