Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whistles #9

Merged
merged 22 commits into from
Dec 11, 2015
Merged

Whistles #9

merged 22 commits into from
Dec 11, 2015

Conversation

RamonGilabert
Copy link
Contributor

screen shot 2015-12-07 at 4 48 29 pm

vadymmarkov
vadymmarkov reviewed Dec 7, 2015
View reviewed changes
Demo/WhisperDemo/WhisperDemo/ViewController.swift
@@ -120,11 +129,20 @@ class ViewController: UIViewController {
}

func presentNotificationDidPress(button: UIButton) {
let announcement = Announcement(title: "Ramon Gilabert", subtitle: "Vadym Markov just commented your post", image: UIImage(named: "avatar"))
let announcement = Announcement(title: "Ramon Gilabert",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@RamonGilabert
Copy link
Contributor Author

The code to display a whistle is the following:

let murmur = Murmur(title: "This is a small whistle", backgroundColor: UIColor(red: 0.975, green: 0.975, blue: 0.975, alpha: 1))

Whistle(murmur)

It will display it as a window in the current context, it supports landscape and portrait. @zenangst, @vadymmarkov, @attila-at-hyper.

The support for landscape and stuff like that needs to be done for Whisper and Shout, but at the moment we don't need it.

@RamonGilabert
Copy link
Contributor Author

screen shot 2015-12-08 at 2 33 39 pm
screen shot 2015-12-08 at 2 33 34 pm

@RamonGilabert RamonGilabert changed the title [WIP] Whistles Whistles Dec 8, 2015
RamonGilabert added a commit that referenced this pull request Dec 11, 2015
@RamonGilabert
Merge pull request #9 from hyperoslo/feature/status-bar
b84262f 
Whistles
@RamonGilabert RamonGilabert merged commit b84262f into master Dec 11, 2015
@RamonGilabert RamonGilabert deleted the feature/status-bar branch December 11, 2015 13:19
@vadymmarkov
Copy link
Contributor

😱

@RamonGilabert
Copy link
Contributor Author

😘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RamonGilabert @vadymmarkov