Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script for collecting task files paths. #32

Merged
merged 24 commits into from
Jan 31, 2024
Merged

Script for collecting task files paths. #32

merged 24 commits into from
Jan 31, 2024

Conversation

mikrise2
Copy link
Collaborator

No description provided.

@mikrise2 mikrise2 requested a review from GirZ0n January 24, 2024 16:29
GirZ0n
GirZ0n requested changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@GirZ0n GirZ0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left several comments. If you have any questions, message me in Slack :-)

jba/README.md Show resolved Hide resolved
jba/README.md Outdated Show resolved Hide resolved
jba/src/processing/tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/src/processing/tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/src/processing/tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/src/processing/tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/tests/processing/test_tasktracker_content_collector.py Outdated Show resolved Hide resolved
@GirZ0n
Copy link
Collaborator

GirZ0n commented Jan 25, 2024

Nastya've merged my PR, so the prepare_course_data.py file is now called collect_course_structure.py

mikrise2 added 3 commits January 25, 2024 16:39
Merge branch 'main' into tasktracker-collector
da3ccdc 
# Conflicts:
#	jba/tests/resources/processing/collect_course_structure/expected_tasktracker_result.yaml
#	pyproject.toml
Fixed pr comments
feff9f2
fixed style
375f83e
@mikrise2 mikrise2 requested a review from GirZ0n January 25, 2024 16:42
mikrise2 and others added 4 commits January 29, 2024 03:33
use _gather_structure
e336775
fix flake8
2a631ef
@GirZ0n
feat: add find_files_by_regex
a66c203
@GirZ0n
feat: add EduInfoFileField, EduStructureNode.gather_leafs_of_type…
cc52015 
… and move regexes

refactor: rename `_gather_structure` to `gather_structure`, `_convert_structure_to_dataframe` to `_convert_course_structure_to_dataframe_recursively` and `get_course_structure` to `convert_course_structure_to_dataframe`
feat: now `convert_course_structure_to_dataframe` accepts a course structure instead of a course path
GirZ0n
GirZ0n requested changes Jan 29, 2024
View reviewed changes
jba/src/processing/tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/src/processing/tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/src/processing/tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/src/processing/tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/src/models/edu_structure.py Outdated Show resolved Hide resolved
jba/src/processing/tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/src/processing/tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/tests/processing/test_tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/tests/processing/test_tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/tests/processing/test_tasktracker_content_collector.py Outdated Show resolved Hide resolved
@mikrise2 mikrise2 requested a review from GirZ0n January 30, 2024 03:45
GirZ0n
GirZ0n requested changes Jan 30, 2024
View reviewed changes
jba/src/processing/tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/src/processing/tasktracker_content_collector.py Outdated Show resolved Hide resolved
core/src/utils/file/file_utils.py Outdated Show resolved Hide resolved
jba/src/processing/tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/src/processing/tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/src/processing/tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/tests/processing/test_tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/tests/processing/test_tasktracker_content_collector.py Outdated Show resolved Hide resolved
jba/src/processing/tasktracker_content_collector.py Show resolved Hide resolved
jba/tests/processing/test_tasktracker_content_collector.py Outdated Show resolved Hide resolved
@mikrise2 mikrise2 requested a review from GirZ0n January 31, 2024 03:37
GirZ0n
GirZ0n approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@GirZ0n GirZ0n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Now everything looks good!

@mikrise2 mikrise2 merged commit 868508e into main Jan 31, 2024
2 checks passed
@mikrise2 mikrise2 deleted the tasktracker-collector branch January 31, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GirZ0n GirZ0n GirZ0n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikrise2 @GirZ0n