Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EELSArctan gradients #55

Merged
merged 5 commits into from
Jun 25, 2024

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Jun 11, 2024

Same as hyperspy/hyperspy#3388.

Progress of the PR

  • Fix EELSArctan gradients,
  • Update link to EDS demos in user guide,
  • fix API reference of some components,
  • [n/a] update user guide (if appropriate),
  • [n/a] added tests,
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:exspy build of this PR (link in github checks)
  • ready for review.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (770f06f) to head (41acbcf).
Report is 84 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   87.77%   88.49%   +0.72%     
==========================================
  Files          67       67              
  Lines        7287     7286       -1     
  Branches     1179     1179              
==========================================
+ Hits         6396     6448      +52     
+ Misses        626      568      -58     
- Partials      265      270       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jlaehne jlaehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions for better readability of some of the docstrings.

exspy/components/eels_cl_edge.py Outdated Show resolved Hide resolved
exspy/components/eels_cl_edge.py Outdated Show resolved Hide resolved
Copy link
Member

@francisco-dlp francisco-dlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, except that the changelog does not include the documentation improvements.

ericpre and others added 2 commits June 24, 2024 17:35
@francisco-dlp francisco-dlp merged commit 0f39dab into hyperspy:main Jun 25, 2024
17 checks passed
@ericpre ericpre added this to the v0.2.1 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants