Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enable more ruff rules: isort, pyflakes, pycodestyle #37

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Apr 17, 2024

Progress of the PR

  • Enable more ruff rules: isort, pyflakes, pycodestyle,
  • [n/a] docstring updated (if appropriate),
  • [n/a] update user guide (if appropriate),
  • [n/a] added tests,
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:holospy build of this PR (link in github checks)
  • ready for review.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.40%. Comparing base (aeaa107) to head (ad4ef20).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   86.40%   86.40%           
=======================================
  Files           7        7           
  Lines         331      331           
  Branches       74       74           
=======================================
  Hits          286      286           
  Misses         27       27           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlaehne jlaehne merged commit feb9833 into hyperspy:main Apr 17, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants