Pin third party actions with SHA #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 82.90% // Head: 82.90% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
=======================================
Coverage 82.90% 82.90%
=======================================
Files 40 40
Lines 8041 8041
Branches 1860 1860
=======================================
Hits 6666 6666
Misses 911 911
Partials 464 464 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
The list of github actions used in this repository are summarised in https://github.com/hyperspy/rosettasciio/network/dependencies |
ericpre
force-pushed
the
pin_third_party_actions
branch
from
eb760cd
to
c6f8e26
Compare
|
Block by LumiSpy/lumispy#100 (comment) |
done |
jlaehne
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on hyperspy/hyperspy#2727, try to pin third party actions with sha. As per https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuring-dependabot-version-updates, I have setup dependabot.yml to get PR to update the github actions automatically - see for example #43.
The idea, is that in case of third party actions (as in not from github), we should review the change in the code of the actions to check that there is no malicious code and use the SHA to make sure the code associated with the tag doesn't change.
Progress of the PR
upcoming_changesfolder (seeupcoming_changes/README.rst),readthedocsdoc build of this PR (link in github checks)