-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
===========================================
- Coverage 81.95% 68.50% -13.46%
===========================================
Files 376 376
Lines 6557 6572 +15
Branches 807 743 -64
===========================================
- Hits 5374 4502 -872
- Misses 1173 2064 +891
+ Partials 10 6 -4
Continue to review full report at Codecov.
|
"lodash-es": "^4.17.15" | ||
}, | ||
"dependencies": { | ||
"tslib": "^2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not a peer dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not clear to me - the ng update command moved it to a dependency from peer dep. I would guess it's to allow better cross-version support, since the tslib had a breaking change, and using multiple copies at runtime isn't problematic except for in bundle size.
TableCellAlignmentType, | ||
TableCellRenderer, | ||
TableCellRendererComponent, | ||
TableColumnConfig | ||
TableColumnConfig, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these ordering changes showing up? Any changes in the default lint rule ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier and tslint have disagreed on the alphabetical ordering wrt caps - I think that finally got resolved in palantir/tslint#4064
"rxjs": "~6.5.4" | ||
"@angular/common": "^10.0.4", | ||
"@angular/core": "^10.0.4", | ||
"@angular/flex-layout": "^10.0.0-beta.32", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am surprised this one is still in beta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.