Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export drilldown filter type #1695

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: export drilldown filter type #1695

wants to merge 1 commit into from

Conversation

arjunlalb
Copy link
Contributor

Description

Export a type.

@arjunlalb arjunlalb requested a review from a team as a code owner June 16, 2022 17:57
@github-actions
Copy link

Unit Test Results

       4 files  ±0     298 suites  ±0   23m 40s ⏱️ + 1m 39s
1 058 tests ±0  1 058 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
1 066 runs  ±0  1 066 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit cea209c. ± Comparison against base commit bb7afd6.

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #1695 (cea209c) into main (bb7afd6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1695   +/-   ##
=======================================
  Coverage   83.75%   83.75%           
=======================================
  Files         889      889           
  Lines       19141    19141           
  Branches     2636     2636           
=======================================
  Hits        16031    16031           
  Misses       2975     2975           
  Partials      135      135
Impacted Files Coverage Δ
...servability/src/pages/explorer/explorer-service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb7afd6...cea209c. Read the comment docs.

anandtiwary
anandtiwary requested changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@anandtiwary anandtiwary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to export it? I would prefer if we can avoid it as it will just create more and more duplicate types.

anandtiwary
anandtiwary reviewed Jun 29, 2022
View reviewed changes
projects/observability/src/pages/explorer/explorer-service.ts
@@ -49,4 +49,4 @@ export class ExplorerService {
}
}

type DrilldownFilter = Omit<Filter, 'metadata' | 'userString' | 'urlString'>;
export type ExplorerDrilldownFilter = Omit<Filter, 'metadata' | 'userString' | 'urlString'>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use FieldFilter instead?

@surajpuvvada surajpuvvada mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandtiwary anandtiwary anandtiwary requested changes

@Christian862 Christian862 Christian862 approved these changes

@itssharmasandeep itssharmasandeep Awaiting requested review from itssharmasandeep

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arjunlalb @Christian862 @anandtiwary