Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variable for S3 bucket location #117

Merged
merged 1 commit into from
Oct 24, 2020

Conversation

ndegory
Copy link
Contributor

@ndegory ndegory commented Jun 6, 2020

The region for the S3 bucket can already be influenced by AWS_REGION or AWS_DEFAULT_REGION. But in some cases these variables may have to be set to another value (for example I'm using helmsman with S3 bucket in us-west-2 for helm-s3, but also SSM parameters in us-east-1).

This MR adds a helm-s3 specific environment variable to force the bucket location.

References #51

Signed-off-by: Nicolas Degory [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2020

Codecov Report

Merging #117 into master will increase coverage by 0.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   39.26%   39.77%   +0.51%     
==========================================
  Files          18       18              
  Lines         354      357       +3     
==========================================
+ Hits          139      142       +3     
  Misses        204      204              
  Partials       11       11              
Impacted Files Coverage Δ
internal/awsutil/session.go 76.19% <100.00%> (+3.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d65cc1d...359ff3b. Read the comment docs.

@maushah
Copy link

maushah commented Jul 20, 2020

Do we have an ETA on the release for this plugin with the helm_s3_region env?

@hypnoglow
Copy link
Owner

LGTM, thank you for the contribution.

@hypnoglow hypnoglow merged commit 508fa41 into hypnoglow:master Oct 24, 2020
@hypnoglow hypnoglow added this to the 0.10.0 milestone Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants