Output instead of CombinedOutput when parsing helm version output #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if there are warnings in the helm output (such as kubeconfig permissions too loose) it will cause the version to erroneously be detected as V2.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
=======================================
Coverage 41.53% 41.53%
=======================================
Files 19 19
Lines 508 508
=======================================
Hits 211 211
Misses 287 287
Partials 10 10
☔ View full report in Codecov by Sentry. |
|
@clhuang Nice one, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if there are warnings in the helm output (such as kubeconfig permissions too loose) it will cause the version to erroneously be detected as V2.