Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify a different base url for charts when pushing and reindexing #46

Closed
wants to merge 3 commits into from

Conversation

willejs
Copy link
Contributor

@willejs willejs commented May 16, 2018

This enables you to publish charts with public s3 urls, which is useful when you are running a public repository.
Ideally the url could be picked up from the s3 package and this would just be a flag?

This is really dependent on this
#43

@codecov-io
Copy link

codecov-io commented May 16, 2018

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   56.79%   56.79%           
=======================================
  Files           3        3           
  Lines          81       81           
=======================================
  Hits           46       46           
  Misses         30       30           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890f235...69756d5. Read the comment docs.

@hypnoglow
Copy link
Owner

hypnoglow commented May 20, 2018

Hi @willejs , thanks for your interest and the contribution.

Let's discuss your proposal in #45

@osterman
Copy link

@willejs have you seen the new design proposal put forth by @hypnoglow ?

#56

@willejs
Copy link
Contributor Author

willejs commented Nov 19, 2018

I am closing this in favour of #56

@willejs willejs closed this Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants