bump aws sdk to support AWS_PROFILE env var and enable role switching #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know this is an older PR, but might as well update to the latest SDK, if there are no regressions. I haven't dug very deep, but it appears that IAM Roles for Service Accounts (released September 4th) isn't supported by this plugin -- most likely due to the older SDK. |
|
This MR actually updated quite a lot of dependencies (e.g. k8s.io/client-go v6.0.0 -> v11.0.0, helm v2.7.2 -> v2.14.1), also lock file was generated with dep v0.5.0+ (this project still uses v0.4.1). But I'm fine with it since deps are pretty outdated, we will migrate to go modules soon, and we will try to do some regression testing before releasing a new version of the plugin. Thanks @willejs |
This was referenced Nov 2, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #69