Now init message has double slash #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horacimacias
force-pushed
the
feature/missingslash
branch
from
e3e0eca
to
826c6eb
Compare
golangcibot
reviewed
Jul 17, 2019
hypnoglow
force-pushed
the
feature/missingslash
branch
from
d3d20fe
to
937e316
Compare
golangcibot
reviewed
Nov 2, 2019
| if strings.HasSuffix(act.uri, "index.yaml") && err == awss3.ErrObjectNotFound { | ||
| return fmt.Errorf("The index file does not exist by the path %s. If you haven't initialized the repository yet, try running \"helm s3 init %s\"", act.uri, path.Dir(act.uri)) | ||
| if strings.HasSuffix(act.uri, indexYaml) && err == awss3.ErrObjectNotFound { | ||
| return fmt.Errorf( |
There was a problem hiding this comment.
ST1005: error strings should not be capitalized (from stylecheck)
|
Thanks! Unfortunately, the patch did not work properly, e.g. for url I added a commit to address this, I hope you don't mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.