Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent tests from crashing when manager is invalid #9

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

earboxer
Copy link
Contributor

@earboxer earboxer commented Mar 16, 2024

Right now, the tests fail for me (presumably because I don't have HYPRCURSOR_THEME set, nor do I have any files that include any hyprcursor theme in them.)

This patch with print the error message instead of segfaulting.

(I think ideally, this repo would contain an example hyprcursor, so the test can be run...)

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea lgtm, why draft doe

@earboxer earboxer marked this pull request as ready for review March 17, 2024 01:39
@vaxerski vaxerski merged commit 8a874fc into hyprwm:main Mar 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants