Add new test & new panel #1388
Open
Add new test & new panel #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 9, 2022 12:01
using arrow keys or keypad. Also perform a fast test on init to detect dead pixels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mr. Henner,
First, my apologies if this is isn't the way to perform a pull request, I'm not sure how it works github.
I added support for a new panel that It wasn't supported by your library or at least I wasn't able to get it work correctly in any of 19 multiplex modes, addr type, etc,. It's a panel sold by a chinese manufacturer, probably other panels in market use same logic to address pixels, I think that it can be useful for other people. https://www.led-card.com/outdoor-p5-smd-fullcolor-module.html
Also I added a new test (12) in demo program to move and change primary color of one pixel for all of screen, it was useful for me to discover the address logic behind my led panel.
Regards,