feat: rework the nodesToString function to output expected element tags
#234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheton
changed the title
nodes-to-string function to output correct tags
This was
linked to
issues
Jul 7, 2022
cheton
force-pushed
the
i18next-scanner-229
branch
from
e13eac5
to
97ef1c7
Compare
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
+ Coverage 90.65% 90.92% +0.27%
==========================================
Files 6 6
Lines 535 562 +27
==========================================
+ Hits 485 511 +26
- Misses 50 51 +1
Continue to review full report at Codecov.
|
cheton
changed the title
nodes-to-string function to output correct tagsnodesToString function to output expected element tags
cheton
force-pushed
the
i18next-scanner-229
branch
from
4e3bc9f
to
c6bc159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
Usage with simple HTML elements like
<br />and others (v10.4.0)https://react.i18next.com/latest/trans-component#usage-with-simple-html-elements-like-less-than-br-greater-than-and-others-v10.4.0