Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend is not merged properly #848

Closed
felixmosh opened this issue Oct 8, 2020 · 0 comments · Fixed by #849
Closed

backend is not merged properly #848

felixmosh opened this issue Oct 8, 2020 · 0 comments · Fixed by #849

Comments

@felixmosh
Copy link
Contributor

Describe the bug

When user providing options.backend it forces the user to provide default loadPath & addPath.

Occurs in next-i18next version

6.0.3<

Steps to reproduce

Provide only options.backend.parse option, the app won't find translation files

Expected behaviour

It should use the default loadPath & addPath if none given by the user

OS (please complete the following information)

  • Device: [e.g. MBP 2018 13"]
  • Browser: [e.g. Chrome 70.0.3538.77]

Additional context

Happens due to the fact that the deep merge here is not merging the combinedConfig variable it self.
@felixmosh felixmosh mentioned this issue Oct 8, 2020
Merged
felixmosh added a commit to felixmosh/next-i18next that referenced this issue Oct 8, 2020
@felixmosh
fix: Deep merge options.backend, closes i18next#848
9ca43ca
@felixmosh felixmosh mentioned this issue Oct 13, 2020
Closed
felixmosh added a commit to felixmosh/next-i18next that referenced this issue Feb 22, 2021
@felixmosh
fix: Deep merge options.backend, closes i18next#848
19b2da4
isaachinman pushed a commit that referenced this issue Feb 22, 2021
@felixmosh
fix: Deep merge options.backend, closes #848 (#849)
0a4f144
isaachinman added a commit that referenced this issue Feb 24, 2021
@isaachinman @franzmoro
@felixmosh @TKone7 @LeonardDrs
v8.0.0 (#965)
7c12340 
* Core changes to support NextJs v10

* Add default config file reading functionality

* Reimplement hoistNonReactStatics

* Update dependencies

* Strip out tests and unnecessary dependencies

* Fix linting setup

* Upgrade core dependencies

* Migrate config options to mirror NextJs

* v8.0.0-beta.0

* Remove deprecated config options and types

* Update example lockfile

* Remove need for locales and defaultLocale entirely

* Update example to use hooks

* Add documentation

* v8.0.0-beta.1

* Add NodeJs v14 to CircleCI

* Create serverSideTranslations.d.ts

* v8.0.0-beta.2

* fix: TS issues for v8-beta (#922)

* fix: export appWithTranslation type

also changed AppWithTranslation type: param is a React Component, not a React Component instance

* chore: remove unused NextI18Next exports

* fix: run-example prod script by adding the build step before it

* v8.0.0-beta.3

* fix: Remove server side code from client bundle (#926)

* Remove static dir entirely

* v8.0.0-beta.4

* feat: Add an ESM entry point to allow better bundle optimizations (#937)

* Add an ESM entry point to allow better tree-shaking & module concatenation

* Include ie11

* fix: added Trans to TS definition v8-beta (#951)

* added Trans to types

* fix: removed unused typess

* refactor: Use serialize-javascript (#954)

* refactor: Use NextJs i18n config API (#955)

* test: Add tests for config and consoleMessage (#956)

* test: Add coverage for createClient (#957)

* refactor: Update eslint config (#958)

* refactor: Update eslint config

* Fix lint

* test: Add e2e coverage via Cypress (#959)

* feat: Disable FS backend when user provides one (#930)

* feat: Disable FS backend when user provides one

* fixup! feat: Disable FS backend when user provides one

* fixup! feat: Disable FS backend when user provides one

* fixup! feat: Disable FS backend when user provides one

* test: Add test coverage to appWithTranslation and serverSideTranslations (#960)

* docs: Update README (#961)

* v8.0.0-beta.5

* docs: Update README (#962)

* v8.0.0-beta.6

* chore: Update example lockfile (#964)

* chore: Update example lockfile

* Update package.json

* fix: Deep merge options.backend, closes #848 (#849)

* fix: Make create-config defaultFile use localeStructure (#966)

use @cescoallegrini modifications from
#934

* Update README.md

Co-authored-by: Léonard Drouillas <[email protected]>

* chore: Lint examples dir (#969)

* fix: Add server side loading of fallbackLng (#970)

* refactor: Remove i18next-http-backend (#971)

* refactor: Remove i18next-http-backend

* Update config.yml

* Update basic.e2e.ts

* refactor: Add react-i18next useSuspense (#973)

* docs: Update README (#975)

* refactor: Add typeof window check to createConfig (#976)

* refactor: Remove serialize-javascript and add configOverride to appWithTranslation (#972)

* refactor: Remove serialize-javascript and add configOverride to appWithTranslation

* Add serializeConfig option

* Add docs

* Update README.md

* docs: Update README (#977)

* Update peerDependencies and version

Co-authored-by: Francesco Moro <[email protected]>
Co-authored-by: Felix Mosheev <[email protected]>
Co-authored-by: Tobias Koller <[email protected]>
Co-authored-by: Filipe Medeiros <[email protected]>
Co-authored-by: Léonard Drouillas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix-848: Deep merge options.backend felixmosh/next-i18next
2 participants
@felixmosh @isaachinman